> On March 4, 2014, 6:16 p.m., Tom Beerbower wrote: > > Just curious... would it be bad to allow an empty config if there was no > > previous version? I'm not sure why you have that restriction. Isn't an > > empty config the same as no config for that type? > > Nate Cole wrote: > Thanks for reviewing! I guess I was thinking that it would help with > "empty config bloat", and not break any existing functionality. For example, > many agent commands do specific property availability/writing, and now if we > start sending a lot of empty configs there could be breakage. I'll check and > report back.
Ok, that makes sense. So if there is a previous version and you want to add an empty version then you need to add something to signify a new empty version. If there is no previous version then adding an empty one just becomes a NOOP. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18737/#review36126 ----------------------------------------------------------- On March 4, 2014, 6:02 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18737/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:02 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-4938 > https://issues.apache.org/jira/browse/AMBARI-4938 > > > Repository: ambari > > > Description > ------- > > * Allow empty configs to be set, only if there was a previous version for the > same type. > * Fix zookeeper stale flag since I was testing ZK to start with. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 10d07b6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml > 3e048a6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > dcee4bf > > Diff: https://reviews.apache.org/r/18737/diff/ > > > Testing > ------- > > Running org.apache.ambari.server.controller.AmbariManagementControllerTest > Tests run: 106, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 129.642 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 12:58.517s > [INFO] Finished at: Tue Mar 04 13:01:08 EST 2014 > [INFO] Final Memory: 18M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
