----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18628/#review36221 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/scripts/hook.py <https://reviews.apache.org/r/18628/#comment67156> Add comment (this is for only client hosts which ...) ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/scripts/shared_initialization.py <https://reviews.apache.org/r/18628/#comment67155> Try to remove this 2 dirs from afterinstall ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py <https://reviews.apache.org/r/18628/#comment67157> Le'ts remove this comments ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py <https://reviews.apache.org/r/18628/#comment67158> let's remove useless for ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_client.py <https://reviews.apache.org/r/18628/#comment67159> we should call this from configure, since we may have configure command in future ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py <https://reviews.apache.org/r/18628/#comment67160> Move this all calls to DataNode class configure, the same for others ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/metainfo.xml <https://reviews.apache.org/r/18628/#comment67161> what's that? can we remove this? ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py <https://reviews.apache.org/r/18628/#comment67162> remove comment ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py <https://reviews.apache.org/r/18628/#comment67163> -/- Let's also call AFTER-INSTALL from BEFORE-START, and add proper comment for this things - Andrew Onischuk On March 3, 2014, 5:49 p.m., Ivan Kozlov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18628/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 5:49 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-4885 > https://issues.apache.org/jira/browse/AMBARI-4885 > > > Repository: ambari > > > Description > ------- > > Refactor (and remove if possible) the resource that has been created in a > previous jira. All logic specific to MR should be moved to MR scripts. The > same thing for HDFS. > > Partially done. Diff for 1-st stack. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/scripts/hook.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/scripts/shared_initialization.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/after-INSTALL/templates/hadoop-env.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py > 51e5cd2 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py > fa19ca3 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py > 4e51c17 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/hook.py > e11bfac > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py > 61ad367 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py > 89b29c6 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/hadoop-env.sh.j2 > 51e2bac > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/hdfs.conf.j2 > ca7baa2 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/slaves.j2 > cbcf6c3 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/taskcontroller.cfg.j2 > d01d37e > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/datanode.py > 57fdb35 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_client.py > 8180689 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py > 50ef5e5 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py > 0397817 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py > dcd7ac4 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py > 98d536c > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/templates/hdfs.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/templates/slaves.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/metainfo.xml > 643b64c > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py > 95ace16 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py > ac1e5ff > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/templates/taskcontroller.cfg.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py > 51e5cd2 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py > d938e74 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > f786eed > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py > e11bfac > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 38494da > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > a8d2fa3 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hdfs.conf.j2 > ca7baa2 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/slaves.j2 > cbcf6c3 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/taskcontroller.cfg.j2 > d01d37e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py > 57fdb35 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py > ec24c7d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py > 5ad9eeb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py > 86a7913 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py > dcd7ac4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > d55488d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/templates/hdfs.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/templates/slaves.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py > 37d467f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py > 108eb89 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/templates/taskcontroller.cfg.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py b096a0d > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 6efa948 > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 058c19a > > ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py > a0d3dca > > ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py > 7a11d6e > > ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py > afc6d3f > > ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_tasktracker.py > 601bdd0 > > ambari-server/src/test/python/stacks/1.3.2/hooks/after-INSTALL/test_after_install.py > PRE-CREATION > > ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py > 3867f48 > > ambari-server/src/test/python/stacks/1.3.2/hooks/before-START/test_before_start.py > 2663839 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 39374e8 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 8e94be3 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 45b84bd > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 98bc3a6 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > ef5c05f > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a28a47e > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > f8ff29e > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 59ac114 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > be5c23e > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > 88448e6 > ambari-server/src/test/python/stacks/2.1.1/YARN/test_apptimelineserver.py > fc1f547 > > Diff: https://reviews.apache.org/r/18628/diff/ > > > Testing > ------- > > security and default deployment on multinode cluster. deployment of mr, hdfs > and "only client" components on separate hosts (default and secure cluster). > > > Thanks, > > Ivan Kozlov > >
