----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18851/#review36399 -----------------------------------------------------------
The change looks good. Could you add a simple test to MinimalRendererTest for this so that we have coverage? - Tom Beerbower On March 6, 2014, 6:27 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18851/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 6:27 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: AMBARI-4976 > https://issues.apache.org/jira/browse/AMBARI-4976 > > > Repository: ambari > > > Description > ------- > > YARN service summary has the following metrics as n/a even though the service > is running and data is available in API. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/MinimalRenderer.java > 2fe4fce > > Diff: https://reviews.apache.org/r/18851/diff/ > > > Testing > ------- > > Unit tests passed. > > > Thanks, > > Dmytro Sen > >
