----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18982/#review36709 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On March 10, 2014, 8:52 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18982/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 8:52 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-5004 > https://issues.apache.org/jira/browse/AMBARI-5004 > > > Repository: ambari > > > Description > ------- > > Bug addresses issue where a service (YARN) defines two services (YARN + > MAPREDUCE2) within the metainfo.xml file. When this is the case, there was > no way to indicate which configs go with which service. Add the ability to > set the config directory. > > The reason that I didn't split MAPREDUCE2 into it's own directory is that > would adversly affect the scripts and agent-side logic setup. That is shared. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > fb622e0 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > c12363c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/core-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-queue-acls.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml > 429c39f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/mapred-queue-acls.xml > 9389ed0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/mapred-site.xml > 943f6bb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml > a5a1e94 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/YARN/configuration/global.xml > 18e42fd > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/YARN/configuration/mapred-queue-acls.xml > 9389ed0 > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/YARN/configuration/mapred-site.xml > 6c9f22a > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/YARN/metainfo.xml > dcbf90b > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 802c9f1 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/config-mr2/mapred-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/metainfo.xml > 6dfff9d > > Diff: https://reviews.apache.org/r/18982/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 12:52.055s > [INFO] Finished at: Mon Mar 10 15:53:00 EDT 2014 > [INFO] Final Memory: 18M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
