-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19153/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen and Sumit Mohanty.


Bugs: AMBARI-4992
    https://issues.apache.org/jira/browse/AMBARI-4992


Repository: ambari


Description
-------

 I prefer the approach of checking if the command queue is empty and then 
picking status commands from last_status. It is better as it can be done every 
10 seconds whereas status commands are send by the server only every minute. I 
assume we still do not store duplicate commands in last_status.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 731ac54 
  ambari-agent/src/main/python/ambari_agent/Controller.py 26985ef 
  ambari-agent/src/test/python/ambari_agent/TestController.py 1e110da 

Diff: https://reviews.apache.org/r/19153/diff/


Testing
-------

Manual cluster installation and running unit tests


----------------------------------------------------------------------
Ran 282 tests in 12.539s

OK

Process finished with exit code 0


Thanks,

Dmitro Lisnichenko

Reply via email to