----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19432/#review37825 -----------------------------------------------------------
Ship it! Don't you want to change the data type to a blob type for Postgres / MySQL. It is probably inconsequential but I would have. - Sid Wagle On March 19, 2014, 11:45 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19432/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 11:45 p.m.) > > > Review request for Ambari and Sid Wagle. > > > Bugs: AMBARI-5153 > https://issues.apache.org/jira/browse/AMBARI-5153 > > > Repository: ambari > > > Description > ------- > > Fixes incorrect column type for table blueprint_configuration specified in > UpgradeCatalog150. > The previous type, String.class, had too long a length value for Oracle. > Switched to byte[]. Also fixed Oracle create script to use CLOB. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java > eb253a4 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql afe6497 > > Diff: https://reviews.apache.org/r/19432/diff/ > > > Testing > ------- > > unit tests > OK > ---------------------------------------------------------------------- > Total run:507 > Total errors:0 > Total failures:0 > ... > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:44.044s > [INFO] Finished at: Wed Mar 19 19:34:38 EDT 2014 > [INFO] Final Memory: 28M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > John Speidel > >
