----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19535/#review38217 -----------------------------------------------------------
Ship it! To sumit's point - this is mostly needed only for YARN for upgrade as of now. The others should be fine since we already add them. We should probably look at a generic way of adding missing configs or removing them. - Mahadev Konar On March 21, 2014, 9:51 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19535/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 9:51 p.m.) > > > Review request for Ambari and Mahadev Konar. > > > Bugs: AMBARI-5178 > https://issues.apache.org/jira/browse/AMBARI-5178 > > > Repository: ambari > > > Description > ------- > > Ambari 1.5.0 assumes that existing configs contain properties, introduced in > 1.5.0 For example, Log message > > > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py", > line 75, in __getattr__ > raise Fail("Configuration parameter '"+self.name+"' was not found in > configurations dictionary!") > Fail: Configuration parameter 'yarn.resourcemanager.nodes.exclude-path' > was not found in configurations dictionary! > > > Bacause params.py for YARN contains > > > rm_nodes_exclude_path = > config['configurations']['yarn-site']['yarn.resourcemanager.nodes.exclude-path'] > > > same for other services > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py > f999683 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py > a523a4f > > Diff: https://reviews.apache.org/r/19535/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Onischuk > >
