----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19618/#review38440 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On March 25, 2014, 3:38 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19618/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 3:38 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-5204 > https://issues.apache.org/jira/browse/AMBARI-5204 > > > Repository: ambari > > > Description > ------- > > Currently, host clean up independently finds processes to kill based on a new > input parameter (java-home). Actually, host check should find the processes > to kill and then let clean-up script read them as input. > The new parameter (if we continue to keep it) must be part of the default > text that UI shows for clean up. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostCleanup.py 83429de > ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 568711b > > Diff: https://reviews.apache.org/r/19618/diff/ > > > Testing > ------- > > test_attribute_logoutput (TestExecuteResource.TestExecuteResource) ... ok > test_attribute_path (TestExecuteResource.TestExecuteResource) ... ok > test_attribute_try_sleep_tries (TestExecuteResource.TestExecuteResource) ... > ok > test_attribute_wait (TestExecuteResource.TestExecuteResource) ... ok > > ---------------------------------------------------------------------- > Ran 285 tests in 128.100s > > OK > > Process finished with exit code 0 > > > Thanks, > > Dmitro Lisnichenko > >
