-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19615/
-----------------------------------------------------------
(Updated March 25, 2014, 1:05 p.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Fixed comment
Bugs: AMBARI-5201
https://issues.apache.org/jira/browse/AMBARI-5201
Repository: ambari
Description
-------
Service alerts show "No alerts" then actual alerts, then "No alerts", back and
forth. This was observed on a 800-node cluster.
The issue is that on large clusters, the call to retrieve Nagios alerts takes a
long time, and eventually times out. The fix is to make the call asynchronous
so as not to block the UI. The reason for Nagios timeout is another issue.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/AlertState.java
929d0bc
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java
4dc8f16
Diff: https://reviews.apache.org/r/19615/diff/
Testing
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Picked up JAVA_TOOL_OPTIONS: -Dapple.awt.UIElement=true
Running org.apache.ambari.server.controller.nagios.NagiosPropertyProviderTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.91 sec
Results :
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Nate Cole