----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19697/#review38753 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On March 26, 2014, 8:40 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19697/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 8:40 p.m.) > > > Review request for Ambari, Mahadev Konar and Vitalyi Brodetskyi. > > > Bugs: AMBARI-5228 > https://issues.apache.org/jira/browse/AMBARI-5228 > > > Repository: ambari > > > Description > ------- > > In fact, gmond configure() is called during install and start, and gmetad > configure() (that generates gmond.master.conf) is called only during install. > Fixed that. Also added missing role_command_order.json files to active stacks > (just a copy of fall-back one at src/resources). > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/1.3.2/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py > 3eed1cf > ambari-server/src/main/resources/stacks/HDP/1.3.3/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py > 258946b > ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py > 7334bcf > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py > ffc15e2 > > Diff: https://reviews.apache.org/r/19697/diff/ > > > Testing > ------- > > test_save_mr_mapping (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... ok > test_tags_count (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... ok > test_update_configs (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... ok > test_update_single_configs (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... > ok > test_update_with_appen_II (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... > ok > test_update_with_append (TestUpgradeScript_HDP2.TestUpgradeHDP2Script) ... ok > > ---------------------------------------------------------------------- > Ran 191 tests in 0.479s > > OK > ---------------------------------------------------------------------- > Total run:505 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
