> On March 27, 2014, 3:07 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java, > > line 213 > > <https://reviews.apache.org/r/19707/diff/1/?file=538144#file538144line213> > > > > Sid, can you please explain of usecase of this code? I could not find > > usages in production and can't get a point of it.
Modifications needed for different implications of Maintenance mode based on what level a operation is triggered. HDFS (non-MM). Had one DN (non-MM) and one DN (MM). HDFS Start and Stop operations skip the DN in MM (as designed), but Restart All does not. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19707/#review38736 ----------------------------------------------------------- On March 27, 2014, 12:43 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19707/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 12:43 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. > > > Bugs: AMBARI-5234 > https://issues.apache.org/jira/browse/AMBARI-5234 > > > Repository: ambari > > > Description > ------- > > 1. The API calls to perform all backend operations needs to provide a > “source” element in the “RequestInfo” properties to identify the logical > level at which the operation is executed. > > Possible levels: > {CLUSTER, SERVICE, HOST_COMPONENT, HOST} > > Note: Service component is analogous to Service, no level specification > needed at the moment. > > 2. The current states for Maintenance mode will be modified to add more > context to the IMPLIED state. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > d392167 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 7f63a41 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 951a619 > > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java > 690b83a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 6a45da9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > ec96627 > > ambari-server/src/main/java/org/apache/ambari/server/state/MaintenanceState.java > 36fea40 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 9bdbd29 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > b3e7c8d > > ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java > 489499a > > Diff: https://reviews.apache.org/r/19707/diff/ > > > Testing > ------- > > Results : > > Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10 > > > Thanks, > > Sid Wagle > >
