> On March 28, 2014, 4:53 p.m., Andrew Onischuk wrote: > > please mock > > os.path.exists > > and > > os.path.islink > > > > so it can work with any possible files present on the tested system
done - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19787/#review38906 ----------------------------------------------------------- On March 28, 2014, 5:04 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19787/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 5:04 p.m.) > > > Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko. > > > Bugs: AMBARI-5264 > https://issues.apache.org/jira/browse/AMBARI-5264 > > > Repository: ambari > > > Description > ------- > > *STR:* > 1) Deploy cluster by default > 2) Go to Ganglia service page -> Config tab > 3) Change value "Ganglia rrdcached base directory" (e.g. > /var/lib/ganglia/rrd8) > 4) Restart Ganglia > 5) Change "Ganglia rrdcached base directory" back to old value (by default - > /var/lib/ganglia/rrds) > 6) Restart Ganglia > > *Expected result:* Ganglia should be restarted successfully > *Current result:* Ganglia Server goes to "installed" state and stuck there > > Error message from gmetad file: > {noformat} > ============================= > Starting hdp-gmetad... > ============================= > Base directory (-b) resolved via file system links! > Please consult rrdcached '-b' documentation! > Consider specifying the real directory (/var/lib/ganglia/rrd8) > chgrp: cannot access `/var/run/ganglia/hdp/rrdcached.sock': No such file or > directory > chgrp: cannot access `/var/run/ganglia/hdp/rrdcached.limited.sock': No such > file or directory > Failed to start /usr/bin/rrdcached > Not starting /usr/sbin/gmetad because starting /usr/bin/rrdcached failed. > > root 16990 0.0 0.0 108164 1560 ? S 03:19 0:00 /bin/bash > --login -c service hdp-gmetad start >> /tmp/gmetad.log 2>&1 ; /bin/ps auwx | > /bin/grep [g]metad >> /tmp/gmetad.log 2>&1 > {noformat} > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py > b27bf61 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py > a1c1b41 > ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py > 9e7630c > ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py > 82cedd8 > > Diff: https://reviews.apache.org/r/19787/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 190 tests in 1.203s > > OK > ---------------------------------------------------------------------- > Total run:504 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Vitalyi Brodetskyi > >
