----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19785/#review38895 -----------------------------------------------------------
Still need to run the ambari-server unit tests. We should run the appropriate unit tests for every check in. If your change causes a failure, it causes a lot of problems when the next guy goes to check in and he can't get all the tests to pass. - Tom Beerbower On March 28, 2014, 3:20 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19785/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 3:20 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: AMBARI-5261 > https://issues.apache.org/jira/browse/AMBARI-5261 > > > Repository: ambari > > > Description > ------- > > Yarn metrics are missing from NODEMANAGER host component > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metrics.json > eda7144 > > Diff: https://reviews.apache.org/r/19785/diff/ > > > Testing > ------- > > Tested manual. API responses after applying the patch: > > { > "href" : > "http://192.168.56.101:8080/api/v1/clusters/c1/services/YARN/components/NODEMANAGER";, > "ServiceComponentInfo" : { > "category" : "SLAVE", > "cluster_name" : "c1", > "component_name" : "NODEMANAGER", > "service_name" : "YARN", > "state" : "STARTED" > }, > "metrics" : { > "yarn" : { > "AllocatedContainers" : 0.0, > "AllocatedGB" : 0.0, > "AvailableGB" : 2.0, > "ContainersCompleted" : 0.0, > "ContainersFailed" : 0.0, > "ContainersIniting" : 0.0, > "ContainersKilled" : 0.0, > "ContainersLaunched" : 0.0, > "ContainersRunning" : 0.0 > } > }, > "host_components" : [ > { > "href" : > "http://192.168.56.101:8080/api/v1/clusters/c1/hosts/dev01.hortonworks.com/host_components/NODEMANAGER";, > "HostRoles" : { > "cluster_name" : "c1", > "component_name" : "NODEMANAGER", > "host_name" : "dev01.hortonworks.com" > } > } > ] > } > > > Thanks, > > Artem Baranchuk > >
