----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19826/#review38995 -----------------------------------------------------------
Ship it! - Mahadev Konar On March 29, 2014, 9:04 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19826/ > ----------------------------------------------------------- > > (Updated March 29, 2014, 9:04 p.m.) > > > Review request for Ambari and Mahadev Konar. > > > Bugs: AMBARI-5272 > https://issues.apache.org/jira/browse/AMBARI-5272 > > > Repository: ambari > > > Description > ------- > > HDFS client configs are not pushed on INSTALL API call. > > Unfortunately we have moved all the hdfs-site/core-site to pre start hooks: > > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=blob;f=ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py;h=3ffcc76eac0cf62d49f34d121d79a22d12b4dc84;hb=HEAD > > > This is casuing the normal api for INSTALL Client to not update the > hdfs-site/core-site configs. > > Fortunately the RESTART api on client configs works because it ends up > calling before-start hooks. But we should fix this. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_client.py > 8180689 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py > ec24c7d > > Diff: https://reviews.apache.org/r/19826/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Onischuk > >
