----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19838/#review39035 -----------------------------------------------------------
Ship it! Ship It! - Andriy Babiichuk On March 31, 2014, 11:34 a.m., Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19838/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 11:34 a.m.) > > > Review request for Ambari and Andriy Babiichuk. > > > Bugs: AMBARI-5274 > https://issues.apache.org/jira/browse/AMBARI-5274 > > > Repository: ambari > > > Description > ------- > > {code} > JMXetricAgent instrumented JVM, see https://github.com/ganglia/jmxetric > Mar 28, 2014 6:40:13 PM info.ganglia.jmxetric.JMXetricAgent premain > SEVERE: Exception starting JMXetricAgent > java.net.UnknownHostException: {0}: Name or service not known > at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) > at java.net.InetAddress$1.lookupAllHostAddr(InetAddress.java:901) > at > java.net.InetAddress.getAddressesFromNameService(InetAddress.java:129 > 3) > at java.net.InetAddress.getAllByName0(InetAddress.java:1246) > at java.net.InetAddress.getAllByName(InetAddress.java:1162) > at java.net.InetAddress.getAllByName(InetAddress.java:1098) > at java.net.InetAddress.getByName(InetAddress.java:1048) > at > info.ganglia.gmetric4j.gmetric.AbstractProtocol.<init>(AbstractProtoc > ol.java:29) > at > info.ganglia.gmetric4j.gmetric.Protocolv31x.<init>(Protocolv31x.java: > 34) > at info.ganglia.gmetric4j.gmetric.GMetric.<init>(GMetric.java:108) > at > info.ganglia.jmxetric.XMLConfigurationService.configureGangliaFromXML > (XMLConfigurationService.java:165) > at > info.ganglia.jmxetric.XMLConfigurationService.configure(XMLConfigurat > ionService.java:67) > at info.ganglia.jmxetric.JMXetricAgent.premain(JMXetricAgent.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. > java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces > sorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > sun.instrument.InstrumentationImpl.loadClassAndStartAgent(Instrumenta > tionImpl.java:382) > at > sun.instrument.InstrumentationImpl.loadClassAndCallPremain(Instrument > ationImpl.java:397) > {code} > > The reason here is this config send from ui: > {code} > ...childopts: > '-javaagent:/usr/lib/storm/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host={0},...' > {code} > > it can't find hostname {0}, however this works fine: > {code} > ...childopts: > '-javaagent:/usr/lib/storm/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host=,port...' > {code} > > So let's leave it as empty if no ganglia server is present > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/configuration/storm-site.xml > 6eca8f9 > ambari-web/app/controllers/wizard/step7_controller.js b02fa8e > > Diff: https://reviews.apache.org/r/19838/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandr Kovalenko > >
