[
https://issues.apache.org/jira/browse/AMBARI-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955402#comment-13955402
]
Scott Creeley commented on AMBARI-5194:
---------------------------------------
[~mahadev] - thanks for the tips...
So, here is the successful unit test:
=============
specific line:
=============
test_checkIptables (TestHostInfo.TestHostInfo) ... ok
=============
All HostInfo tests
=============
test_analyze_yum_output (TestHostInfo.TestHostInfo) ... ok
test_analyze_yum_output_err (TestHostInfo.TestHostInfo) ... ok
test_analyze_zypper_out (TestHostInfo.TestHostInfo) ... ok
test_checkFolders (TestHostInfo.TestHostInfo) ... ok
test_checkIptables (TestHostInfo.TestHostInfo) ... ok
test_checkLiveServices (TestHostInfo.TestHostInfo) ... ok
test_checkUsers (TestHostInfo.TestHostInfo) ... ok
test_dirType (TestHostInfo.TestHostInfo) ... ok
test_etcAlternativesConf (TestHostInfo.TestHostInfo) ... ok
test_getReposToRemove (TestHostInfo.TestHostInfo) ... ok
test_hadoopVarLogCount (TestHostInfo.TestHostInfo) ... ok
test_hadoopVarRunCount (TestHostInfo.TestHostInfo) ... ok
test_hostinfo_register (TestHostInfo.TestHostInfo) ... ok
test_hostinfo_register_suse (TestHostInfo.TestHostInfo) ... ok
test_javaProcs (TestHostInfo.TestHostInfo) ... ok
test_osdiskAvailableSpace (TestHostInfo.TestHostInfo) ... ok
test_perform_package_analysis (TestHostInfo.TestHostInfo) ... ok
so it passed, but I had to modify the TestHostInfo.py for that particular test,
as it was still expecting the values from the old method. So what is the
process for that, do I now need a separate JIRA so I can update the
TestHostInfo.py as well? Below is what I changed (old routine used faulty
returncode, new routine uses boolean values)
result = hostInfo.checkIptables()
self.assertTrue(result == True)
result = hostInfo.checkIptables()
self.assertFalse(result == False)
> Improve User Experience during install - iptables warning
> ---------------------------------------------------------
>
> Key: AMBARI-5194
> URL: https://issues.apache.org/jira/browse/AMBARI-5194
> Project: Ambari
> Issue Type: Improvement
> Components: agent
> Affects Versions: 1.4.4
> Environment: all
> Reporter: Scott Creeley
> Assignee: Scott Creeley
> Labels: Ambari, HostCheck
> Fix For: 1.6.0
>
> Attachments: AMBARI-5194.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> improve the HostInfo.py (Host Check) during the ambari installer process,
> particularly for step 3 of the process where the nodes are registered and
> confirmed. In particular this JIRA will address the erroneous iptables check
> that currently always returns a value of 0 which indicates in the script that
> iptables is running and active, even when the iptables have actually been
> flushed. This results in an erroneous warning message.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
