----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19932/#review39265 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On April 2, 2014, 11:45 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19932/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 11:45 a.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-5318 > https://issues.apache.org/jira/browse/AMBARI-5318 > > > Repository: ambari > > > Description > ------- > > HBASE should have state "INSTALLED" when there is no active HBASE_MASTER. The > correct rule is - if (service_is_hbase && !is_hbase_active) : service_status > = STOPPED; > regardless hbase_master quantity. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 39322a7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 2adac34 > > Diff: https://reviews.apache.org/r/19932/diff/ > > > Testing > ------- > > Added new unit tests for ServiceResourceProvider. > > All existing ambari-server tests pass ... > > Results : > > Tests run: 1515, Failures: 0, Errors: 0, Skipped: 10 > ... > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:04.079s > [INFO] Finished at: Wed Apr 02 11:25:12 EDT 2014 > [INFO] Final Memory: 35M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
