----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19872/#review39410 -----------------------------------------------------------
Ship it! Ran 300 tests in 11.325s OK - Dmytro Sen On April 3, 2014, 6:49 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19872/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 6:49 a.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-5303 > https://issues.apache.org/jira/browse/AMBARI-5303 > > > Repository: ambari > > > Description > ------- > > 1. Let's throw exception not exit(1) when we have our os now detected this > makes all of tests badly finish in case or one error. (like BUG-15442) > > 2. Let's do all the methods static. > > 3. Let's do class in commons only utitily, and move "def main" to different > file which uses this one, and is put to agents. > > 4. Also did we removed old code os os_check_type.sh? If no we should do that. > > 5. Also on ubuntu it fails during build, because it doesn't add __init__.py to > deb package, let's add the whole folder common_functions to the package > > > Diffs > ----- > > ambari-agent/pom.xml 8edceec > ambari-agent/src/main/python/ambari_agent/Facter.py 552f0e0 > ambari-agent/src/main/python/ambari_agent/HostCleanup.py da16dec > ambari-agent/src/main/python/ambari_agent/HostInfo.py 81cf29a > ambari-agent/src/main/python/resource_management/core/system.py cb4c766 > ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py > 6e4973e > ambari-agent/src/test/python/ambari_agent/TestAmbariAgent.py 330581e > ambari-agent/src/test/python/ambari_agent/TestController.py 63f5b22 > ambari-agent/src/test/python/ambari_agent/TestHardware.py 682b932 > ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py c6a834d > ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py b624212 > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py b199907 > ambari-agent/src/test/python/ambari_agent/TestMain.py 7dab39e > ambari-agent/src/test/python/ambari_agent/TestRegistration.py e63976e > ambari-agent/src/test/python/ambari_agent/TestSecurity.py 9ef0d0c > ambari-common/src/main/python/common_functions/os_check.py e6591b5 > ambari-server/pom.xml ff6cd76 > ambari-server/src/main/python/ambari-server.py ad1ec3c > ambari-server/src/main/python/bootstrap.py ff7bf33 > ambari-server/src/main/python/os_check_type.py PRE-CREATION > ambari-server/src/test/python/TestBootstrap.py 76e6e43 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 4cb6837 > > Diff: https://reviews.apache.org/r/19872/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
