----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20077/#review39693 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/20077/#comment72275> Let's modify to LOG.error("Failed to get local hostname, assuming localhost"); to make things clear. Also need Mahadev feedback whether we should ignore this error or fail completely. - Dmitro Lisnichenko On April 7, 2014, 4:05 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20077/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 4:05 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-5370 > https://issues.apache.org/jira/browse/AMBARI-5370 > > > Repository: ambari > > > Description > ------- > > Unit tests failing with UnknownHostException in InetAddress > This could be caused by BUG > http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7180557 (or some similar > issues) > So we can implement try-catch block to ensure we won't get such exception in > any deployment. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > ed0ceb4 > > Diff: https://reviews.apache.org/r/20077/diff/ > > > Testing > ------- > > Running org.apache.ambari.server.controller.internal.HostResourceProviderTest > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.828 sec > > > Thanks, > > Vitalyi Brodetskyi > >
