----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20114/#review39800 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/Role.java <https://reviews.apache.org/r/20114/#comment72405> Can we open a Jira to move Roles completely to the stack? ambari-server/src/main/java/org/apache/ambari/server/Role.java <https://reviews.apache.org/r/20114/#comment72404> Are we using "HANDLER" to indicate a multi-daemon Service component? Maybe this should be renamed to "__SERVERS"? - Sid Wagle On April 8, 2014, 5:23 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20114/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 5:23 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Dmytro Sen, Srimanth Gunturi, > and Sid Wagle. > > > Bugs: AMBARI-5378 > https://issues.apache.org/jira/browse/AMBARI-5378 > > > Repository: ambari > > > Description > ------- > > * Add Flume as a service in 2.0.6 (for 2.0/2.1 stacks) > * Remove the old Flume definition from 1.3.x > * NOTE: This patch is only to get the service work started and unblock the > UI. It doesn't have to be perfect, just pass some tests so we can continue > to work FE and BE in tandem. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/Role.java f0024a4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java > b81c024 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java > b658712 > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 3747319 > ambari-server/src/main/resources/ganglia_properties.json 8a488b6 > ambari-server/src/main/resources/role_command_order.json 84610ca > ambari-server/src/main/resources/scripts/install_flume.sh a6e59e8 > > ambari-server/src/main/resources/stacks/HDP/1.3.0/services/FLUME/configuration/global.xml > f1fa4de > > ambari-server/src/main/resources/stacks/HDP/1.3.0/services/FLUME/metainfo.xml > 87ff4b3 > > ambari-server/src/main/resources/stacks/HDP/1.3.2.GlusterFS/services/FLUME/configuration/global.xml > f1fa4de > > ambari-server/src/main/resources/stacks/HDP/1.3.2.GlusterFS/services/FLUME/metainfo.xml > 185f685 > ambari-server/src/main/resources/stacks/HDP/1.3.2/role_command_order.json > 84610ca > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/FLUME/configuration/global.xml > f1fa4de > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/FLUME/metainfo.xml > bebb54e > ambari-server/src/main/resources/stacks/HDP/1.3.3/role_command_order.json > 84610ca > > ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/role_command_order.json > 550f885 > ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json > 4eec50a > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/global.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/templates/flume.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/templates/log4j.properties.j2 > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.0/role_command_order.json > 4eec50a > ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json > ded1d23 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 9ff575d > > ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java > 4e827ab > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractPropertyProviderTest.java > ff2d0d2 > > ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleGraphTest.java > d8075f2 > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 61dca49 > > ambari-server/src/test/resources/stacks/HDP/1.3.4/services/FLUME/metainfo.xml > bebb54e > ambari-server/src/test/resources/stacks/HDP/2.0.6/role_command_order.json > 550f885 > ambari-server/src/test/resources/stacks/HDP/2.0.7/role_command_order.json > 84610ca > ambari-server/src/test/resources/stacks/HDP/2.0.8/role_command_order.json > 84610ca > ambari-server/src/test/resources/stacks/HDP/2.1.1/role_command_order.json > 84610ca > > Diff: https://reviews.apache.org/r/20114/diff/ > > > Testing > ------- > > Running tests for stack:2.0.6 service:FLUME > test_configure_default (test_flume.TestFlumeHandler) ... ok > test_start_default (test_flume.TestFlumeHandler) ... ok > test_stop_default (test_flume.TestFlumeHandler) ... ok > > ---------------------------------------------------------------------- > Ran 3 tests in 0.038s > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:20.067s > [INFO] Finished at: Mon Apr 07 21:02:19 EDT 2014 > [INFO] Final Memory: 20M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
