> On April 9, 2014, 12:21 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java, > > lines 131-134 > > <https://reviews.apache.org/r/20133/diff/1/?file=553410#file553410line131> > > > > Is a merge required when just deleting anyway? Are there dependencies > > not shown in this diff?
The merge makes sure that entity is not detached (unknown to the entity manager). If you try to remove a detached entity you will get an IllegalArgumentException. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20133/#review39842 ----------------------------------------------------------- On April 8, 2014, 10:10 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20133/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 10:10 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-5399 > https://issues.apache.org/jira/browse/AMBARI-5399 > > > Repository: ambari > > > Description > ------- > > For predefined view instances (defined in view.xml) instance data stored in > the Ambari database is not loaded when the server is started. > > Populate the view instance entities defined in the view.xml with any instance > data loaded from the Ambari database. > > Add tests and an ambari-views example to illustrate the use of view > persistence. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > 34cd732 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > cc8ae48 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > b91cb99 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ViewInstanceDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 14581a7 > ambari-views/examples/phone-list-view/docs/index.md PRE-CREATION > ambari-views/examples/phone-list-view/docs/phone_1.png PRE-CREATION > ambari-views/examples/phone-list-view/docs/phone_2.png PRE-CREATION > ambari-views/examples/phone-list-view/docs/phone_3.png PRE-CREATION > ambari-views/examples/phone-list-view/docs/phone_4.png PRE-CREATION > ambari-views/examples/phone-list-view/docs/phone_5.png PRE-CREATION > ambari-views/examples/phone-list-view/pom.xml PRE-CREATION > > ambari-views/examples/phone-list-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java > PRE-CREATION > ambari-views/examples/phone-list-view/src/main/resources/WEB-INF/web.xml > PRE-CREATION > ambari-views/examples/phone-list-view/src/main/resources/view.xml > PRE-CREATION > ambari-views/examples/pom.xml 94a9579 > > Diff: https://reviews.apache.org/r/20133/diff/ > > > Testing > ------- > > Results : > > Tests run: 1522, Failures: 0, Errors: 0, Skipped: 9 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:08.223s > [INFO] Finished at: Tue Apr 08 17:28:22 EDT 2014 > [INFO] Final Memory: 36M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
