----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20222/#review40045 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On April 10, 2014, 5:06 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20222/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 5:06 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-5428 > https://issues.apache.org/jira/browse/AMBARI-5428 > > > Repository: ambari > > > Description > ------- > > Sometimes unittests fail (got 3 fails for 20 runs) > ====================================================================== > FAIL: testGenerateManifest (TestManifestGenerator.TestManifestGenerator) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/ambari_agent/TestManifestGenerator.py", > line 76, in testGenerateManifest > self.assertTrue(writeParamsMock.called) > AssertionError > ====================================================================== > FAIL: test_overwrite_repos (TestPuppetExecutor.TestPuppetExecutor) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/ambari_agent/TestPuppetExecutor.py", > line 142, in test_overwrite_repos > self.assertTrue(puppetInstance.reposInstalled) > AssertionError > > > Diffs > ----- > > ambari-agent/src/test/python/ambari_agent/TestManifestGenerator.py 7e6ab81 > ambari-agent/src/test/python/ambari_agent/TestPuppetExecutor.py c5c3bdc > > Diff: https://reviews.apache.org/r/20222/diff/ > > > Testing > ------- > > Ran unit tests 20 times with no fails > > > Thanks, > > Dmitro Lisnichenko > >
