----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20263/#review40164 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/20263/#comment73072> Lets revert back to explicit imports. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/20263/#comment73073> Should we rename to setNagiosRestartRequired? Also, we should do the same when host components are removed. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/20263/#comment73074> The overall approach of treating Nagios as special makes sense. The configuration version change under the cover may be risky as it does not confirm to the pattern of how we handle config. Let's me comment on the JIRA. - Sumit Mohanty On April 11, 2014, 4:30 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20263/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 4:30 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-5445 > https://issues.apache.org/jira/browse/AMBARI-5445 > > > Repository: ambari > > > Description > ------- > > Nagios config tag version is updated every time when bew service component > hosts added. > > stale_config for Nagios service was never set , because nagios haven't been > dependent from any configs, including global > nagios should be dependent on global config. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 2e2822c > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/configuration/global.xml > 61a2b90 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/metainfo.xml > 74f6c2b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml > 61a2b90 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml > 5c13516 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > ca4ac80 > > Diff: https://reviews.apache.org/r/20263/diff/ > > > Testing > ------- > > All service tests passed > > + Tested manually. > > > Thanks, > > Dmytro Sen > >
