> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 359 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line359> > > > > Should we report back the request id when this is an import operation?
We print the response json to console with request id. > On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 411 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line411> > > > > Default should be export, I think. Currently using this for import so the choice. > On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 413 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line413> > > > > Does export do a console out if no file is provided? Good point, I will set a default path and print the path to log. Do not like console json output. > On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 418 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line418> > > > > What are these arguments for? To provide a comma separated list of hosts. Script allows user to not provide a hosts json but a comma separated list of hosts. > On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 421 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line421> > > > > We would need to accept host/port user/password as parameters for > > silent option. Agreed, will make those changes. > On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 324 > > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line324> > > > > Can we add some form of validation on the hosts json file and tests > > against some sample invalid formatted files? Agreed I will create a separate Jira for this. AMBARI-5465 - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20244/#review40153 ----------------------------------------------------------- On April 11, 2014, 1:09 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20244/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 1:09 a.m.) > > > Review request for Ambari, Mahadev Konar and Sumit Mohanty. > > > Bugs: AMBARI-5398 > https://issues.apache.org/jira/browse/AMBARI-5398 > > > Repository: ambari > > > Description > ------- > > Blueprints allow for repeatable touch-less cluster installation. We need to > allow for repeatable creation of clusters with little effort. > > *Objective*: > Create a script to deploy a cluster with arbitrary number of nodes with few > large master nodes and deploy the cluster using an existing blueprint. > > > Diffs > ----- > > ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json > PRE-CREATION > ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json > PRE-CREATION > > ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/20244/diff/ > > > Testing > ------- > > > Thanks, > > Sid Wagle > >
