> On April 17, 2014, 11:18 a.m., Dmytro Sen wrote: > > Ship It!
But rename "private String custom_command;" according to JCC - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20417/#review40638 ----------------------------------------------------------- On April 16, 2014, 5:21 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20417/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 5:21 p.m.) > > > Review request for Ambari, Dmytro Sen and Sumit Mohanty. > > > Bugs: AMBARI-5480 > https://issues.apache.org/jira/browse/AMBARI-5480 > > > Repository: ambari > > > Description > ------- > > I add custom command name to CommandReport and allow to update configs for > "RESTART" command and ignore any status from it(to avoid adding new > transitions). Also we can make remove lags without additional field in > CommandReport and just apply new configTags for every custom command and > ignore their status but additional field with custom command name will be > useful in other cases. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 53191d7 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bf93c10 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandReport.java > e5863fd > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 6a8373d > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > acd401d > > Diff: https://reviews.apache.org/r/20417/diff/ > > > Testing > ------- > > [INFO] Exclude: **/*.json > [INFO] 63 resources included (use -debug for more details) > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 34 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [2.494s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.316s] > [INFO] Ambari Web ........................................ SUCCESS [6.231s] > [INFO] Ambari Views ...................................... SUCCESS [2.375s] > [INFO] Ambari Server ..................................... SUCCESS > [13:22.273s] > [INFO] Ambari Agent ...................................... SUCCESS [29.030s] > [INFO] Ambari Client ..................................... SUCCESS [0.457s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:03.908s > [INFO] Finished at: Wed Apr 16 20:17:50 FET 2014 > [INFO] Final Memory: 32M/325M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
