-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 17, 2014, 10:49 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Addressed all of the comments except adding "blacklist" and "whilelist"
properties back into the stack definition since these properties do not always
have empty as valid values and there is no correct default value.
Verified deploying a cluster works for HDP-1.3.3, HDP-2.0 and HDP-2.1 thorough
the UI with these changes.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to
determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty
values in {{global.xml}}. This effects UI because we do not show a service
restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml
453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml
bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml
d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml
04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml
900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml
9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml
34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml
4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml
7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml
ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml
f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml
16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml
f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml
b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml
cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml
ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml
d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml
1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml
ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml
f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml
5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml
984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml
310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml
c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml
f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml
9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml
130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml
9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
98bc4e8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/data/site_properties.js 35c6404
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
