----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20481/#review40766 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On April 18, 2014, 12:59 p.m., Alexandr Antonenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20481/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:59 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-5507 > https://issues.apache.org/jira/browse/AMBARI-5507 > > > Repository: ambari > > > Description > ------- > > Refactor related to *App.MainServiceInfoSummaryView* class: > * move methods {{#setMetrics()}} and {{#setFlumeAgentMetric()}} to > *App.MainDashboardServiceFlumeView* > * rename property {{#collapsedMetrics}} to {{#collapsedSections}} > * add methods and property documentation > > > Diffs > ----- > > ambari-web/app/templates/main/service/info/summary.hbs e488656 > ambari-web/app/views/main/service/info/summary.js 6592f8f > ambari-web/app/views/main/service/services/flume.js a42d074 > > Diff: https://reviews.apache.org/r/20481/diff/ > > > Testing > ------- > > > Thanks, > > Alexandr Antonenko > >
