----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20449/#review41011 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On April 17, 2014, 3:28 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20449/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 3:28 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: AMBARI-5494 > https://issues.apache.org/jira/browse/AMBARI-5494 > > > Repository: ambari > > > Description > ------- > > Ability to use custom jmx port from *-site.xml files to get jmx metrics > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > b9f48dd > contrib/ambari-scom/ambari-scom-server/pom.xml 1e82b91 > > contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/AbstractResourceProvider.java > 5d7e3db > > contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ConfigurationProvider.java > PRE-CREATION > > contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/AbstractResourceProviderTest.java > f4e2446 > > contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ConfigurationProviderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20449/diff/ > > > Testing > ------- > > Results : > > Tests run: 78, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-scom-server --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: .git/ > [INFO] Exclude: **/.gitignore > [INFO] Exclude: **/.gitattributes > [INFO] Exclude: .idea/ > [INFO] Exclude: pass.txt > [INFO] Exclude: .DS_Store > [INFO] Exclude: .iml/ > [INFO] Exclude: .classpath > [INFO] Exclude: .project > [INFO] Exclude: .settings > [INFO] Exclude: MSPL-LICENSE > [INFO] Exclude: **/*.resources > [INFO] Exclude: **/*.rtf > [INFO] Exclude: **/*.snk > [INFO] Exclude: **/*.cs > [INFO] Exclude: **/*.json > [INFO] 51 resources included (use -debug for more details) > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 51 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 10.988s > [INFO] Finished at: Thu Apr 17 18:19:38 EEST 2014 > [INFO] Final Memory: 12M/243M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
