----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20793/#review41704 -----------------------------------------------------------
Overall looks good, just a small fixes mentioned ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py <https://reviews.apache.org/r/20793/#comment75274> Could we remove this function? ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 <https://reviews.apache.org/r/20793/#comment75275> we have here and in other places normal_check_interval mentioned two times ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/functions.py <https://reviews.apache.org/r/20793/#comment75273> a names is a bit confusing, can we call that is_jdk_greater_6 or get version and check later in code. ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py <https://reviews.apache.org/r/20793/#comment75276> Can we also remove the corresponding template file snmpd.conf.j2 from both stacks? - Andrew Onischuk On April 29, 2014, 9:36 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20793/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 9:36 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty. > > > Repository: ambari > > > Description > ------- > > * Removed installation and various agent activities surrounding SNMP. > * Use JMX for java7. > * Ignore CPU util for java6. I left in the old commands "just in case" (per > Jeff) > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py > 98b5dea > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py > 61e04f8 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py > 35f22ba > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check-v2.j2 > 7382621 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/templates/health_check.j2 > e659a5a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/metainfo.xml > a90b33a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_cpu.php > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/functions.py > f997993 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py > 1f75057 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py > ef034d1 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 > 79f88f0 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > b45d110 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 0ae8b19 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > a8500c0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > 2a7ac77 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check-v2.j2 > 7382621 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/health_check.j2 > e659a5a > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml > da06b24 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_cpu.php > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/functions.py > f997993 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py > 1f75057 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py > e8f0150 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 > da37d73 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > b77e77b > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py > 547e3d9 > > ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py > fb1c134 > > ambari-server/src/test/python/stacks/1.3.2/hooks/before-START/test_before_start.py > 35061f7 > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py > 0839995 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > 0c1babd > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > 5a15689 > > Diff: https://reviews.apache.org/r/20793/diff/ > > > Testing > ------- > > Ambari-server python: > ---------------------------------------------------------------------- > Ran 203 tests in 0.722s > > OK > ---------------------------------------------------------------------- > Total run:548 > Total errors:0 > Total failures:0 > OK > AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf > > All: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:38.905s > [INFO] Finished at: Mon Apr 28 16:15:41 EDT 2014 > [INFO] Final Memory: 20M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
