----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20864/#review41738 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On April 29, 2014, 6:04 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20864/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 6:04 p.m.) > > > Review request for Ambari, Sumit Mohanty and Sid Wagle. > > > Bugs: AMBARI-5623 > https://issues.apache.org/jira/browse/AMBARI-5623 > > > Repository: ambari > > > Description > ------- > > Simple patch to do a null/length check on a passed list to the DAO - the fact > that it's zero length is causing the SQL error. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 241c1fd > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20864/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:32.863s > [INFO] Finished at: Tue Apr 29 13:53:06 EDT 2014 > [INFO] Final Memory: 20M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
