> On April 25, 2014, 4:29 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, > > line 632 > > <https://reviews.apache.org/r/20501/diff/5/?file=566189#file566189line632> > > > > Incomplete javadoc
Private method, no javadocs available elsewhere. > On April 25, 2014, 4:29 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java, > > line 423 > > <https://reviews.apache.org/r/20501/diff/5/?file=566192#file566192line423> > > > > This is only looking at cluster scoped configuration and is ignoring > > host group scoped configuration. Validation needs to be done on the > > complete configuration. Moved validation to the method which formulates Create Command and look at the properties provided by the user. For passwords the validateConfiguration should allow properties to be skipped if universal password property exists. > On April 25, 2014, 4:29 p.m., John Speidel wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml, > > line 48 > > <https://reviews.apache.org/r/20501/diff/5/?file=566198#file566198line48> > > > > why is this a space ' ' and not null ''? No changes here, reverted to as it was. No impact to UI. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20501/#review41474 ----------------------------------------------------------- On April 25, 2014, 11:26 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20501/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 11:26 p.m.) > > > Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and > Srimanth Gunturi. > > > Bugs: AMBARI-5515 > https://issues.apache.org/jira/browse/AMBARI-5515 > > > Repository: ambari > > > Description > ------- > > Hive deployment via Blueprints works when the following configurations were > added to the blueprint. > Several of the properties do exist in the stack definition, but most don't. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 5fef43a > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > 08a545f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 91632c0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java > e5cbdf7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > ea2fdec > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 90017ac > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > acc5f4a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml > f3c274a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml > 3a6ed76 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml > e164c64 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml > 6336a70 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml > 61a2b90 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml > 781fdcb > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 40e4bf3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > 9e12c63 > > ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml > 7d35558 > > Diff: https://reviews.apache.org/r/20501/diff/ > > > Testing > ------- > > mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [1.966s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s] > [INFO] Ambari Web ........................................ SUCCESS [9.690s] > [INFO] Ambari Views ...................................... SUCCESS [1.835s] > [INFO] Ambari Server ..................................... SUCCESS > [14:38.002s] > [INFO] Ambari Agent ...................................... SUCCESS [15.533s] > [INFO] Ambari Client ..................................... SUCCESS [0.522s] > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sid Wagle > >
