----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20838/#review41829 -----------------------------------------------------------
bump - John Speidel On April 29, 2014, 3:02 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20838/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 3:02 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-5618 > https://issues.apache.org/jira/browse/AMBARI-5618 > > > Repository: ambari > > > Description > ------- > > When provisioning a cluster via a blueprint, there currently is a restriction > that a host may only be associated with a single host group. If a user > attempts to map a host to multiple host groups, strange errors are reported > back to the user which do not explain the problem. > This work will validate that a host is only mapped to one host group early > and will provide a good error message to the user if there is an attempt to > map multiple host groups to a host. > > { "status" : 400, > "message" : "A host may only be mapped to a single host group at this time. > The following hosts are mapped to more than one host group: [host.novalocal]" > } > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 2ca70f5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 32bd72e > > Diff: https://reviews.apache.org/r/20838/diff/ > > > Testing > ------- > > Functional Tests: > Tested that the proper 400 response is returned to the user when attempting > to map multiple host groups to a single host. > > Unit Tests: > Added new unit test to validate 400 response. > > All existing unit tests pass: > > Results : > > Tests run: 1571, Failures: 0, Errors: 0, Skipped: 9 > ... > Total run:548 > Total errors:0 > Total failures:0 > OK > ... > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:15.426s > [INFO] Finished at: Mon Apr 28 20:28:36 EDT 2014 > [INFO] Final Memory: 21M/123M > > > Thanks, > > John Speidel > >
