----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20892/#review41840 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On April 30, 2014, 2:52 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20892/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 2:52 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-5599 > https://issues.apache.org/jira/browse/AMBARI-5599 > > > Repository: ambari > > > Description > ------- > > Enhancement of allowing empty configs added a regression when switching to a > different existing config. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > de3db69 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > ff3f08a > > Diff: https://reviews.apache.org/r/20892/diff/ > > > Testing > ------- > > Added additional code path testing to AMCTest > > Results : > > Tests run: 1571, Failures: 0, Errors: 0, Skipped: 9 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:27.249s > [INFO] Finished at: Wed Apr 30 10:45:24 EDT 2014 > [INFO] Final Memory: 20M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
