----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20942/#review42026 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On May 1, 2014, 1:25 p.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20942/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 1:25 p.m.) > > > Review request for Ambari, Tom Beerbower and Yusaku Sako. > > > Bugs: AMBARI-5616 > https://issues.apache.org/jira/browse/AMBARI-5616 > > > Repository: ambari > > > Description > ------- > > The code submission provides the implementation for a new Ambari View for > Pig; allowing execution of Pig queries on a cluster. > > > Diffs > ----- > > contrib/views/pig/pom.xml PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/PigServiceRouter.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/InstanceKeyValueStorage.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/KeyValueStorage.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/LocalKeyValueStorage.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/PersistentConfiguration.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/Storage.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/ContextConfigurationAdapter.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/FilteringStrategy.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/Indexed.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/ItemNotFound.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/OnlyOwnersFilteringStrategy.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/Owned.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/PersonalResource.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/utils/StorageUtil.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/CRUDResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/PersonalCRUDResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/SharedCRUDResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileResource.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceProvider.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/models/PigJob.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/utils/JobPolling.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptResourceProvider.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/models/PigScript.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/udf/UDFResourceManager.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/udf/UDFResourceProvider.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/udf/UDFService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/udf/models/UDF.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/BaseService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/Request.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonRequest.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/FilePaginator.java > PRE-CREATION > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/HdfsApi.java > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/.gitignore PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/README.md PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/app.js PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/index.html > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/static/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/static/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/static/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/static/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/edit.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/jobResults.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/modal/pigModal.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pig.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigHistory.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigJob.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigScriptEdit.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigScriptEditResults.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigScriptList.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigUdfs.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/poll.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/util/pigUtilAlert.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/models/file.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/models/pig_job.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/models/pig_script.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/models/udf.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/router.js PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/jobResults.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pig.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigHistory.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigIndex.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigJob.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigScriptEdit.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigScriptEditIndex.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigScriptEditResults.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigScriptList.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/pigUdfs.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/styles/style.less > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/application.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/index.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/loading.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/history.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/index.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/job.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/jobEdit.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/jobResults.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/jobResultsOutput.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/jobStatus.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/loading.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/modal/confirmdelete.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/modal/createScript.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/modal/createUdf.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/modal/modalLayout.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/scriptEdit.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/scriptEditIndex.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/scriptList.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/scriptResults.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/scriptResultsNav.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/udfs.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/util/alert-content.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/util/alert.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/util/pigHelper.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/pig/util/script-nav.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/jobResults.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/modal/confirmDelete.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/modal/createScript.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/modal/createUdf.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/modal/pigModal.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/pigHistory.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/pigJob.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/pigUdfs.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/scriptEdit.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/scriptList.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/scriptResults.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/scriptResultsNav.js > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/util/pigUtilAlert.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/bin PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/bower.json PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/config.coffee PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/collection/collection.js.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/collection/generator.json > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/controller/controller.js.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/controller/generator.json > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/model/generator.json > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/model/model.js.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/route/generator.json > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/route/route.js.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/template/generator.json > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/template/template.hbs.hbs > PRE-CREATION > > contrib/views/pig/src/main/resources/ui/pig-web/generators/view/generator.json > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/generators/view/view.js.hbs > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/package.json PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/test/spec.coffee > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/vendor/emacs.js > PRE-CREATION > contrib/views/pig/src/main/resources/view.xml PRE-CREATION > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/BasePigTest.java > PRE-CREATION > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/HDFSTest.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/FileTest.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/HelpTest.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTest.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestHDFSUnmanaged.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestUnmanaged.java > PRE-CREATION > > contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/UDFTest.java > PRE-CREATION > contrib/views/pom.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/20942/diff/ > > > Testing > ------- > > The code submission includes unit tests which all execute successfully. > > > Thanks, > > Erik Bergenholtz > >
