-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21121/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
Bugs: AMBARI-5689
https://issues.apache.org/jira/browse/AMBARI-5689
Repository: ambari
Description
-------
setupAgent.py will fail in such test scenarios:
In case if script will be started without parameters - script will failed
without reasonable error output.
In case if script will be started without passed project version string and
repository in the system will contain at least one available version of agent.
For example:
function call retcode = getOptimalVersion("") will always return exitcode 1, as
any founded in repository version will not match blank string
In case if script will be started without passed project version.
Error output will fail, because of projectVersion variable will contain "None"
type, not string.
In case if repository will contain several versions of packages with versions
like "1.0.1, 1.0.3-SNAPSHOT, 1.0.5" getAvaliableAgentPackageVersions and
findNearestAgentPackageVersion functions will return wrong result "1.0.1,
1.0.3" and version 1.0.5 will be missed.
Diffs
-----
ambari-common/src/main/python/common_functions/os_check.py 1256a07
ambari-server/src/main/python/bootstrap.py 9e5ae1b
ambari-server/src/main/python/setupAgent.py 0c2851a
ambari-server/src/test/python/TestBootstrap.py bae5c1e
ambari-server/src/test/python/TestOSCheck.py a71aea4
ambari-server/src/test/python/TestSetupAgent.py 35edadf
Diff: https://reviews.apache.org/r/21121/diff/
Testing
-------
----------------------------------------------------------------------
Ran 203 tests in 1.630s
OK
----------------------------------------------------------------------
Total run:548
Total errors:0
Total failures:0
OK
Thanks,
Dmitro Lisnichenko
