----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21117/#review42332 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On May 6, 2014, 4:32 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21117/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 4:32 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-5677 > https://issues.apache.org/jira/browse/AMBARI-5677 > > > Repository: ambari > > > Description > ------- > > Add 'version' resources under views and above instances. For example ... > > > http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/ > > { > "href" : "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/";, > "ViewInfo" : { > "view_name" : "WEATHER" > }, > "versions" : [ > { > "href" : > "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/1.0.0";, > "ViewVersionInfo" : { > "version" : "1.0.0", > "view_name" : "WEATHER" > } > }, > { > "href" : > "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/2.0.0";, > "ViewVersionInfo" : { > "version" : "2.0.0", > "view_name" : "WEATHER" > } > } > ] > } > > > http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/1.0.0 > > { > "href" : > "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/1.0.0";, > "ViewVersionInfo" : { > "archive" : > "/var/lib/ambari-server/resources/views/weather-view-1.0.0.jar", > "label" : "Weather", > "parameters" : [ > { > "name" : "cities", > "description" : "The list of cities.", > "required" : true > }, > { > "name" : "units", > "description" : "The units (metric or imperial).", > "required" : false > } > ], > "version" : "1.0.0", > "view_name" : "WEATHER" > }, > "instances" : [ > { > "href" : > "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/1.0.0/instances/EUROPE";, > "ViewInstanceInfo" : { > "instance_name" : "EUROPE", > "version" : "1.0.0", > "view_name" : "WEATHER" > } > }, > { > "href" : > "http://c6401.ambari.apache.org:8080/api/v1/views/WEATHER/versions/1.0.0/instances/US_WEST";, > "ViewInstanceInfo" : { > "instance_name" : "US_WEST", > "version" : "1.0.0", > "view_name" : "WEATHER" > } > } > ] > } > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 49ed8ab > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java > a068183 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewExternalSubResourceService.java > 3617a63 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java > 0b0acad > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java > 45d7d2f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java > 52dd608 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > c7e54c6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > bc93e7b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java > a71ab70 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > d47f003 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > a133ad2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > c6557f2 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > 862e2e1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewExternalSubResourceProvider.java > e0af2ef > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > a45cb39 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java > 08c0c1d > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java > 4da48d6 > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewVersionResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java > b2dac99 > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java > 6029ee5 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java > 0003ac8 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > daedbca > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java > befb7fe > > Diff: https://reviews.apache.org/r/21117/diff/ > > > Testing > ------- > > Manual test of all ambari-view examples. > > Added new unit tests. All existing tests pass ... > > Results : > > Tests run: 1586, Failures: 0, Errors: 0, Skipped: 9 > > … > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:45.634s > [INFO] Finished at: Tue May 06 12:01:28 EDT 2014 > [INFO] Final Memory: 36M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
