-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21124/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-5690
    https://issues.apache.org/jira/browse/AMBARI-5690


Repository: ambari


Description
-------

For blueprint creation, validate all non-password required properties have been 
set in the blueprint.
For cluster creation via a blueprint, validate that all required password 
properties have been set in configuration or that a 'default_password' property 
has been included in the request. Password properties can be set in the 
blueprint cluster or host group configurations or as part of the cluster create 
call as either cluster or host group properties.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 1d2e5cc 
  
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
 89afb14 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5ee07e0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 353b58f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 e884e97 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
 b02c723 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
 fe5734a 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
 c61c109 

Diff: https://reviews.apache.org/r/21124/diff/


Testing
-------

Functional Testing:
Manually tested validation at both blueprint and cluster creation time.
Tested with 'default_password', blueprint configuration and configuration 
specified at cluster creation time.

Unit Tests:
Added new unit tests
* Still need to run all unit tests since trunk is currently broken due to 
missing licenses.
Will update when all I have successfully run all unit tests.


Thanks,

John Speidel

Reply via email to