----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21160/#review42411 -----------------------------------------------------------
Ship it! LGTM - Dmitro Lisnichenko On May 7, 2014, 4:47 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21160/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 4:47 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower. > > > Bugs: AMBARI-5696 > https://issues.apache.org/jira/browse/AMBARI-5696 > > > Repository: ambari > > > Description > ------- > > Hive/Oozie (and possibly other components in the future) make use of a > relational database to store its metadata. > When the user wants to use an existing, external database, it's easy to > mistype the credentials/JDBC string. Currently, such mistakes are not caught > until service install or start, at which point it's a pain to reconfigure and > fix the issue. > API should expose the ability to check database connectivity given the JDBC > connection string, username, and password, so that the UI can expose this to > the end user in the Customize Services page. > > > Diffs > ----- > > ambari-server/pom.xml 5b465eb > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificatorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21160/diff/ > > > Testing > ------- > > Listening for transport dt_socket at address: 5007 > Running > org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec > > Results : > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Vitalyi Brodetskyi > >
