> On May 12, 2014, 2:20 p.m., Nate Cole wrote: > > contrib/views/pom.xml, lines 91-108 > > <https://reviews.apache.org/r/21321/diff/1/?file=578477#file578477line91> > > > > Can jar names be wildcarded? Maybe do something like > > files-${project.version}-jar-with-dependencies.jar? That way a > > command-line setting of version won't result in an empty resource > > collection.
Good catch. I don't need to be so specific with the name. I think that *-dependencies.jar would work. Ultimately it will just be *.jar after we fix the packaging of the pig and files jars. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21321/#review42690 ----------------------------------------------------------- On May 12, 2014, 2:08 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21321/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 2:08 p.m.) > > > Review request for Ambari, Mahadev Konar and Nate Cole. > > > Bugs: AMBARI-5732 > https://issues.apache.org/jira/browse/AMBARI-5732 > > > Repository: ambari > > > Description > ------- > > As part of Ambari-1.6.0, we need to package Pig and File Views as part of the > ambari-server RPM. > > After the user runs: > yum install ambari-server > > Pig and File Views should be available under: > /var/lib/ambari-server/resources/views > > Note that we should not hardcode these Views as part of the general build > process. The Maven job should be modified such that it takes a list of Views > to package. This way, as part of HWX-distributed Ambari, we can choose to > package a specific set of Views (via HWX's Jenkins job), while anyone else > building Ambari can choose to package different sets of Views depending on > the parameters chosen for the Maven package command. > > > Diffs > ----- > > ambari-server/pom.xml 5b465eb > contrib/views/files/pom.xml 6ea35d4 > contrib/views/pig/pom.xml 757089d > contrib/views/pom.xml 5dc4038 > pom.xml 38d0aef > > Diff: https://reviews.apache.org/r/21321/diff/ > > > Testing > ------- > > Manual tests ... > > 1) From contrib/views/ run 'mvn clean package'. Verify that the Pig and > Files view archives are copied to contrib/views/target/views/. > 2) From ambari-server run ' mvn package rpm:rpm'. Verify that the Pig and > File view archives are packaged as part of the ambari-server RMP... > > /var/lib/ambari-server/resources/views/pig-0.0.1-SNAPSHOT-jar-with-dependencies.jar > > /var/lib/ambari-server/resources/views/files-0.0.1-SNAPSHOT-jar-with-dependencies.jar > > > Thanks, > > Tom Beerbower > >
