-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21385/#review42847
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On May 13, 2014, 5:41 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21385/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 5:41 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-5735
>     https://issues.apache.org/jira/browse/AMBARI-5735
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced --noproxy curl option with a no_proxy env variable. Also fixed one 
> minor issue.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py
>  c59d601 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py
>  393f1b1 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py
>  276410b 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_namenodes_ha.sh
>  a0b348e 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_nodemanager_health.sh
>  5b2a93f 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_templeton_status.sh
>  6aa944b 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_webui.sh
>  2be3388 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py
>  4ab267a 
>   
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/files/templetonSmoke.sh
>  6ec9a0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  f5a5921 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  3bad0e7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py
>  1445b24 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_namenodes_ha.sh
>  a0b348e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_nodemanager_health.sh
>  5b2a93f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_templeton_status.sh
>  6aa944b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh
>  a40fdf1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py
>  6feb7b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/files/templetonSmoke.sh
>  f27503b 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_client.py 98f6321 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 
> 1366520 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 700bb66 
>   
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py
>  575cf13 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b210e3b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> cbb6da3 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py f1486d3 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  4677871 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> 0e56eb0 
> 
> Diff: https://reviews.apache.org/r/21385/diff/
> 
> 
> Testing
> -------
> 
> Manual test on Centos 6 and Centos 5. Also tried installing cluster with a 
> wrong proxy defined. Agent still fails in this configuration (another issue), 
> but curl does not.
> 
> ----------------------------------------------------------------------
> Ran 203 tests in 0.692s
> 
> OK
> ----------------------------------------------------------------------
> Total run:550
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to