----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21466/#review43116 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java <https://reviews.apache.org/r/21466/#comment77129> should remove toEntity as it is no longer used ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java <https://reviews.apache.org/r/21466/#comment77128> What happens if null is passed into remove? - John Speidel On May 15, 2014, 12:10 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21466/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 12:10 a.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower. > > > Bugs: AMBARI-5767 > https://issues.apache.org/jira/browse/AMBARI-5767 > > > Repository: ambari > > > Description > ------- > > DELETE > ambariHost:8080/api/v1/blueprints/myBlueprint > > results in 500 error: > 18:08:10,817 WARN [qtp1102737706-22] ServletHandler:514 - > /api/v1/blueprints/newhadoopcluster > java.lang.StringIndexOutOfBoundsException: String index out of range: -1 > at java.lang.String.substring(String.java:1911) > at > org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395) > at > org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311) > at > org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206) > at > org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > 003590f > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java > 0cbaedc > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > b611551 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java > c157729 > > Diff: https://reviews.apache.org/r/21466/diff/ > > > Testing > ------- > > Reproduced exception and verified the fix. > > > Thanks, > > Sid Wagle > >
