----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21284/#review42619 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On May 9, 2014, 9:53 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21284/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 9:53 p.m.) > > > Review request for Ambari and Sid Wagle. > > > Bugs: AMBARI-5722 > https://issues.apache.org/jira/browse/AMBARI-5722 > > > Repository: ambari > > > Description > ------- > > New code added breaks all agent parsing when the Ambari Server is not hosted > on a cluster host. > > If you try to deploy a new cluster on a clean database, you'll encounter the > error. > > File > "/usr/lib/python2.6/site-packages/ambari_agent/CustomServiceOrchestrator.py", > line 113, in runCommand > json_path = self.dump_command_to_json(command) > File > "/usr/lib/python2.6/site-packages/ambari_agent/CustomServiceOrchestrator.py", > line 209, in dump_command_to_json > command'clusterHostInfo' = > manifestGenerator.decompressClusterHostInfo(command'clusterHostInfo') > File "/usr/lib/python2.6/site-packages/ambari_agent/manifestGenerator.py", > line 116, in decompressClusterHostInfo > indexes = convertRangeToList(v) > File "/usr/lib/python2.6/site-packages/ambari_agent/manifestGenerator.py", > line 57, in convertRangeToList > raise AgentException.AgentException("Broken data in given range, expected - > ""m-n"" or ""m"", got : " + str(r)) > AgentException: 'Broken data in given range, expected - m-n or m, got : -1β > The command being sent is > {hs_host=[2], namenode_host=[1], snamenode_host=[2], zookeeper_hosts=[0-2], > ganglia_server_host=[1], nm_hosts=[0], ganglia_monitor_hosts=[0-2], > all_hosts=[c6403.ambari.apache.org, c6401.ambari.apache.org, > c6402.ambari.apache.org], rm_host=[2], app_timeline_server_hosts=[2], > slave_hosts=[0], ambari_server_host=[-1], nagios_server_host=[1], > all_ping_ports=[8670:0-2]} > > Notice the ambari-server-host which was added in that commit; itβs value is > β-1β which would not parse correctly in manifestGenerator.py > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 767a97d > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py > 7c5ac6e > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py > c588ffc > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py > 43f375d > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py > 393f1b1 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py > 276410b > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py > 1f21780 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_namenodes_ha.sh > a0b348e > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_nodemanager_health.sh > 5b2a93f > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_templeton_status.sh > 6aa944b > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_webui.sh > 2be3388 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py > 4ab267a > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py > ae4da20 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/files/templetonSmoke.sh > 6ec9a0f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py > eeb21e8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 9ac5667 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 861ed55 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > 3bad0e7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py > 1445b24 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py > 5ab1753 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_namenodes_ha.sh > a0b348e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_nodemanager_health.sh > 5b2a93f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_templeton_status.sh > 6aa944b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh > a40fdf1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py > 6feb7b1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py > 59451aa > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/files/templetonSmoke.sh > f27503b > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java > 7bfe605 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_client.py 98f6321 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py > 1366520 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 700bb66 > ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json > 9295c69 > ambari-server/src/test/python/stacks/1.3.2/configs/default.json 84dcc8d > > ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json > 57ec6d9 > ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 44f6506 > ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json > b824d40 > > ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py > f68da7b > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b210e3b > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py > cbb6da3 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py f1486d3 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json > c45918d > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 3561b4b > > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json > 0a5ccae > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json > cb81436 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json f152ed7 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json 6f60980 > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json ffa1c55 > ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json > f403cde > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > e70debb > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > 0e56eb0 > ambari-server/src/test/python/stacks/2.1/configs/default.json d80c28d > ambari-server/src/test/python/stacks/2.1/configs/secured.json 68b04d0 > > Diff: https://reviews.apache.org/r/21284/diff/ > > > Testing > ------- > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 34 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [1.650s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.230s] > [INFO] Ambari Web ........................................ SUCCESS [9.283s] > [INFO] Ambari Views ...................................... SUCCESS [1.350s] > [INFO] Ambari Server ..................................... SUCCESS > [13:29.605s] > [INFO] Ambari Agent ...................................... SUCCESS [7.190s] > [INFO] Ambari Client ..................................... SUCCESS [0.361s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:50.095s > [INFO] Finished at: Fri May 09 17:50:31 EDT 2014 > [INFO] Final Memory: 24M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
