----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21807/#review43716 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On May 22, 2014, 2:24 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21807/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 2:24 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-5857 > https://issues.apache.org/jira/browse/AMBARI-5857 > > > Repository: ambari > > > Description > ------- > > * Decouple ClusterEntity, StateEntity, RequestEntity to prepare for > non-cluster based actions. > * @Ignore'd an unrelated test that fails with a PermGen error (it was > annoying me, and we already have a filed JIRA for it). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 2104bd6 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > b253138 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > b3b5279 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > fcb3d66 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java > cd78722 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > f80ac7d > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > 2a353b4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java > 388ce3a > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > d1f5a6d > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 59b14c1 > ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java > 7729874 > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java > f322bfb > > Diff: https://reviews.apache.org/r/21807/diff/ > > > Testing > ------- > > * Manual verification that deploying/stop/start did not change > * Unit tests: > > Results : > > Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:03.061s > [INFO] Finished at: Thu May 22 09:25:11 EDT 2014 > [INFO] Final Memory: 20M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
