----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21859/#review43832 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On May 23, 2014, 2:13 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21859/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 2:13 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-5869 > https://issues.apache.org/jira/browse/AMBARI-5869 > > > Repository: ambari > > > Description > ------- > > Seems that HostInfo.py on agent try to collect information about a firewall > state in the system, but firewall was not even installed, as result > /sbin/SuSEfirewall2 status command failed. > We can ignore the firwall call if the path does not exists. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 64e9cb9 > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py baf95f0 > > Diff: https://reviews.apache.org/r/21859/diff/ > > > Testing > ------- > > test_action_create_properties_simple > (TestPropertiesFileResource.TestPropertiesFIleResource) ... ok > test_action_create_properties_with_metacharacters > (TestPropertiesFileResource.TestPropertiesFIleResource) ... ok > > ---------------------------------------------------------------------- > Ran 284 tests in 4.566s > > OK > > > Thanks, > > Dmitro Lisnichenko > >
