----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22031/#review44278 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On May 29, 2014, 7:08 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22031/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 7:08 p.m.) > > > Review request for Ambari and Tom Beerbower. > > > Bugs: AMBARI-5931 > https://issues.apache.org/jira/browse/AMBARI-5931 > > > Repository: ambari > > > Description > ------- > > Now parser of clusterproperties.txt relies on comments like #hosts or #ha > settings. > It's not a reliable way to do, due customer can skip comments and as result > Ambari Server will fail. > > > Diffs > ----- > > > contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java > fb356a2 > > contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java > e8d15f4 > > Diff: https://reviews.apache.org/r/22031/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17.599s > [INFO] Finished at: Thu May 29 21:06:09 EEST 2014 > [INFO] Final Memory: 38M/449M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
