----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22090/#review44403 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On May 30, 2014, 6:34 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22090/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 6:34 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-5973 > https://issues.apache.org/jira/browse/AMBARI-5973 > > > Repository: ambari > > > Description > ------- > > We need to add checks for Transparent Huge Page. With it enabled, we have > pretty horrible performance, and it's enabled by default on RHEL. > > Reference: <https://access.redhat.com/site/documentation/en- > US/Red_Hat_Enterprise_Linux/6/html/Performance_Tuning_Guide/s-memory- > transhuge.html> > > What we need to do pseudo code: > > if (`cat /sys/kernel/mm/redhat_transparent_hugepage/enabled` != 'never'); > then > echo never > /sys/kernel/mm/redhat_transparent_hugepage/enabled > end > > We need to add a check, and then add the 'echo never' to the python script. > > > Diffs > ----- > > ambari-agent/src/main/python/resource_management/core/system.py 90a2559 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py > 9b200af > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py > 49a01cf > > ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py > 3a0bf93 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py > bb68560 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py > 852a439 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > a1196a8 > > Diff: https://reviews.apache.org/r/22090/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
