----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22138/#review44503 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On June 2, 2014, 4:15 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22138/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 4:15 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-5988 > https://issues.apache.org/jira/browse/AMBARI-5988 > > > Repository: ambari > > > Description > ------- > > Looks like "monitoringService" property is not processed when calculating > stack extension at > org.apache.ambari.server.api.util.StackExtensionHelper#mergeServices . > That means that this property will not be inherited. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fc113f4 > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > 910de1d > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 2a6de41 > > ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java > cedcb11 > > ambari-server/src/test/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/NAGIOS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/22138/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [1.844s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.268s] > [INFO] Ambari Web ........................................ SUCCESS [9.978s] > [INFO] Ambari Views ...................................... SUCCESS [2.308s] > [INFO] Ambari Server ..................................... SUCCESS > [13:22.239s] > [INFO] Ambari Agent ...................................... SUCCESS [5.066s] > [INFO] Ambari Client ..................................... SUCCESS [0.041s] > [INFO] Ambari Python Client .............................. SUCCESS [0.486s] > [INFO] Ambari Groovy Client .............................. SUCCESS [3.724s] > [INFO] Ambari Shell ...................................... SUCCESS [4.282s] > > > Thanks, > > Dmytro Sen > >
