----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22153/#review44715 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment79186> Can socket.socket() throw anything? ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment79187> I think python will auto-close out of scope; but in case of s.connect() failure then s.close() won't be called ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment79188> I think the message of raising a Fail is printed, so no need to print the message first. Verify in script.py. Also whitespace ;) - Nate Cole On June 2, 2014, 3:34 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22153/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 3:34 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-5800 > https://issues.apache.org/jira/browse/AMBARI-5800 > > > Repository: ambari > > > Description > ------- > > The Hive server start check only looks for a PID when returning a successful > starting condition. Although the Hive service check depends on the server > starting, the server might not be up and running even though the PID exists. > > This changes the Hive start scripts to ensure they do not return a success > until the server because active and the connection port is open. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py > 568f6ec > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py > 596eec9 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 6cd9f52 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py cec393a > > Diff: https://reviews.apache.org/r/22153/diff/ > > > Testing > ------- > > Existing tests patched, new tests added to cover timeout period. > > ---------------------------------------------------------------------- > Total run:562 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > >
