> On June 4, 2014, 4:17 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java, > > lines 138-149 > > <https://reviews.apache.org/r/22208/diff/2/?file=603472#file603472line138> > > > > Can just propagate the IOException. A generic Exception is thrown when > > this function is false anyway. At very least write a log statement showing > > what happened to help the user make it right.
I agree with you. I'll throw Exception with more informative message - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22208/#review44719 ----------------------------------------------------------- On June 4, 2014, 4:07 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22208/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 4:07 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-6008 > https://issues.apache.org/jira/browse/AMBARI-6008 > > > Repository: ambari > > > Description > ------- > > > [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4 > Using python /usr/bin/python2.6 > Upgrading stack of ambari-server > WARNING: could not change directory to "/root" > > Ambari Server 'upgradestack' completed successfully. > > > Ambari should consider the validity of the data if was specified the invalid > HDP version and give the correct message about this. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java > 77ec069 > ambari-server/src/main/python/ambari-server.py 6ad94d5 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java > PRE-CREATION > ambari-server/src/test/python/TestAmbariServer.py c2d868d > > Diff: https://reviews.apache.org/r/22208/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
