----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22423/#review45432 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On June 11, 2014, 4:31 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22423/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 4:31 p.m.) > > > Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6069 > https://issues.apache.org/jira/browse/AMBARI-6069 > > > Repository: ambari > > > Description > ------- > > Unit tests need to verify that the response from the component for the server > version matches that from AmbariMetaInfo and not a pre-defined string. QE > alters the version string during their tests, so the comparison needs to come > from AmbariMetaInfo. > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java > 3ece6ac > > Diff: https://reviews.apache.org/r/22423/diff/ > > > Testing > ------- > > mvn -Dtest=org.apache.ambari.server.controller.RootServiceResponseFactoryTest > test > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up JAVA_TOOL_OPTIONS: -Dapple.awt.UIElement=true > Running org.apache.ambari.server.controller.RootServiceResponseFactoryTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.004 sec > > > Thanks, > > Jonathan Hurley > >
